mining

[dragon slayer]

is there a reason why mining is still all hardcoded?

[Xuri]

Same reason why a lot of other stuff is still hardcoded, I guess. Lack of time/people.

[dragon slayer]

Okay well i started working on a js script to do mining only problem I'm having is adding all this ids LOL.

Code: Select all

				220, 221, 222, 223, 224, 225, 226, 227, 228, 229,
				230, 231, 236, 237, 238, 239, 240, 241, 242, 243,
				244, 245, 246, 247, 252, 253, 254, 255, 256, 257,
				258, 259, 260, 261, 262, 263, 268, 269, 270, 271,
				272, 273, 274, 275, 276, 277, 278, 279, 286, 287,
				288, 289, 290, 291, 292, 293, 294, 296, 296, 297,
				321, 322, 323, 324, 467, 468, 469, 470, 471, 472,
				473, 474, 476, 477, 478, 479, 480, 481, 482, 483,
				484, 485, 486, 487, 492, 493, 494, 495, 543, 544,
				545, 546, 547, 548, 549, 550, 551, 552, 553, 554,
				555, 556, 557, 558, 559, 560, 561, 562, 563, 564,
				565, 566, 567, 568, 569, 570, 571, 572, 573, 574,
				575, 576, 577, 578, 579, 581, 582, 583, 584, 585,
				586, 587, 588, 589, 590, 591, 592, 593, 594, 595,
				596, 597, 598, 599, 600, 601, 610, 611, 612, 613,

				1010, 1741, 1742, 1743, 1744, 1745, 1746, 1747, 1748, 1749,
				1750, 1751, 1752, 1753, 1754, 1755, 1756, 1757, 1771, 1772,
				1773, 1774, 1775, 1776, 1777, 1778, 1779, 1780, 1781, 1782,
				1783, 1784, 1785, 1786, 1787, 1788, 1789, 1790, 1801, 1802,
				1803, 1804, 1805, 1806, 1807, 1808, 1809, 1811, 1812, 1813,
				1814, 1815, 1816, 1817, 1818, 1819, 1820, 1821, 1822, 1823,
				1824, 1831, 1832, 1833, 1834, 1835, 1836, 1837, 1838, 1839,
				1840, 1841, 1842, 1843, 1844, 1845, 1846, 1847, 1848, 1849,
				1850, 1851, 1852, 1853, 1854, 1861, 1862, 1863, 1864, 1865,
				1866, 1867, 1868, 1869, 1870, 1871, 1872, 1873, 1874, 1875,
				1876, 1877, 1878, 1879, 1880, 1881, 1882, 1883, 1884, 1981,
				1982, 1983, 1984, 1985, 1986, 1987, 1988, 1989, 1990, 1991,
				1992, 1993, 1994, 1995, 1996, 1997, 1998, 1999, 2000, 2001,
				2002, 2003, 2004, 2028, 2029, 2030, 2031, 2032, 2033, 2100,
				2101, 2102, 2103, 2104, 2105,

				0x453B, 0x453C, 0x453D, 0x453E, 0x453F, 0x4540, 0x4541,
				0x4542, 0x4543, 0x4544,	0x4545, 0x4546, 0x4547, 0x4548,
				0x4549, 0x454A, 0x454B, 0x454C, 0x454D, 0x454E,	0x454F

i just wanted to make sure tileid will know what this our if i click the shovel and click the ground

[dragon slayer]

bump hehee still trying to found out if i can use this ids with if(tileid = ?

[Xuri]

The current hardcoded implementation of mining doesn't rely solely on IDs. The pseudo code goes something like this:

Code: Select all

// ini-settings are not exposed to JS, 
// but if you're overriding the hardcoded mining stuff anyway,
// you don't really need it?

switch( MineCheck setting in UOX.INI )
{
	case 0: // Mining is allowed everywhere
		return true; 
	case 1: // Mining is allowed only on rock, mountain and cave tiles
		var tileID = socket.GetWord( 17 );
		var targX = socket.GetWord( 11 );
		var targY = socket.GetWord( 13 );
		var targZ = socket.GetSByte( 16 ) + GetTileHeight( socket.GetWord( 17 ) );
	
		if( targZ == 0 ) // Check to see if we're targeting a dungeon floor
		{
			if(( tileID >= 0x053B && tileID <= 0x054F ) || ( tileID >= 0x0551 && tileID <= 0x0553 ) || tileID == 0x056A )
				return true;
		}
		if targZ >= 0 ) // mountain not likely to be below 0, but you never know
		{
			if( tileID != 0 ) // target is an item
			{
				//Finding name of a tile is not available in the JS engine, so you'd probably have to compare against tileID instead of name here:
				
				if( tilename equals "rock", or "mountain" or "cave" )
					return true;
			}
			else
			{
				// target is a maptile
				tileID = GetTileIDAtMapCoord( targX, targY, mChar.worldNumber );
				
				//Finding name of a tile is not available in the JS engine, so you'd probably have to compare against tileID instead of name here:
				if( tilename equals "rock", or "mountain" or "cave" )
					return true;
			}
	case 2: // Mining is allowed everywhere (again, used to be region-based)
		return true;
	default:
		return false;;
}

[dragon slayer]

I will take that code see what i can come up with and post here see if you approve