Client crash on certain speech colors?

[Xuri]

When I was checking into the bug Jediman reported earlier about magic fields/blade spirits, I had to start a new character to test with since the one I had already would constantly get a client crash whenever I tried casting any spells.

After a bit of debugging, I figured out that the reason for the client crashes was my character's speech text colour. In the WSC files, my character had the following values:
Speech=0x7620,0x23

I changed it to the following, and the client stopped crashing:
Speech=0x58,0x23

Now, I don't know how that specific text colour (the one that crashed the client) got set for my character, but it might be an idea to implement some safeguards in UOX3 against invalid/dangerous text-hues.

[Grimson]

Hmmm, I think I did already block some color values that crashed the client. I'll have a look at it once I'm at home...

[giwo]

Yes, we do have some checks on speech colors. If we have missed a few, it would be relatively easy to add new values to the list.

[giwo]

Check out line 3339 of CChar.cpp and line 1549 of CItem.cpp

You should be able to simply add any invalid colors to that list. I'm not certain if we have anywhere else in the code that checks speech color.