SpiderMonkey

Want to discuss changes to the UOX3 source code? Got a code-snippet you'd like to post? Anything related to coding/programming goes here!
Post Reply
punt
VIP
Posts: 244
Joined: Wed Mar 24, 2004 7:46 pm
Has thanked: 0
Been thanked: 9 times

SpiderMonkey

Post by punt »

Xuri,
I did a few things, and decided to just go ahead and byte the bullet and help get SpiderMonkey moved over.

Now to do this, I needed a cleaner setup, so just so you know, I created the following:

uoxjs--|
|-src. <<< this has all cpp files I got rid of all autoconf type stuff, and got rid of Config.h/config.h files. I will eventually get rid of Platform.h. Just for less files
|
|-include. << put all the includes in here. I deleted jsapi.h, as going to use the standard one for v59 SpiderMonkey
|
|-lib. << This would be where SpiderMonkey goes. Right now, I have int installed systemwide, so not using it
|
|-bin. << this is where the executable would be put.


The reason I bring this up, is I am thinking about you want to handle merging (if I ever get there). There will be substantial changes, for things like "jsval" is gone, and now had JS::Value, and all the macros are gone and have their own method. That is just the first obvious change

Talk to you later

punt
punt
VIP
Posts: 244
Joined: Wed Mar 24, 2004 7:46 pm
Has thanked: 0
Been thanked: 9 times

Post by punt »

In addition, jsobj.h isn't a public file, and the internal structure has changed. So that goes to the heart of JSEcapsuate. One should give some thought about this. If you stay on on the Spidermonky 1.6 , this is going to die anyway, since eventually it just won't work on newer platforms. But the conversion isn't going to be easy (why one should never ever go to the internals of a library unless taking on maintaining that library as well).

I see there are the following files that use that:
SEFuncations.cpp
cScript.cpp
UOXJSPropertyFuncs.cpp
UOXJSMethods.cpp

So, some food for thought.
Post Reply