[FIXED] Major bug with pile of 65535 coins

[Fresshness]

I have reported this bug a while ago and I had heard something that this was fixed. However, with the current version of UOX3, it's still there.

I am using the Stranf's World starter kit.

BUG: When you have a pile of 65535 coins, and you move a portion of that amount away, you will end up with 2 piles of coins:
- a pile with 65535 coins (the amount dragged away is not subtracted)
- a second pile with the amount you indicated to move away

This bug is 100% reliably repeatable.

Irrelevant continuation of the experiment:

I noticed the extra amounts of cash do not get registered with the vendors. While I had roughly a million gold coins stuffed in several pouches; the vendor 'noticed' I had only a mere 8k or so.

Obviously this additional 'bug' is irrelavant when the causing bug is solved (imho)

[giwo]

I was unabled to reproduce either of these bugs in UOX3 v0.98-3.6d.

Please provide your UOX3 version number, the EXACT steps to reproduce, and any pertinent information.

[Fresshness]

OK, I'm sorry if my information was a bit minimalistic.

I'm using the latest UOX3 version v0.98-3.6d together with cluox 1.4.

First off; how to reproduce:

- kill monsters untill you have the required amount (in my world, I have extremely wealthy brigands carrying 2500 - 10000 gold each, so that way it really doesn't take long to acquire the money).

- once the pile is collected in backpack, move a *portion* of the pile elsewhere in the backpack (right next side to it is just fine).

I have found that the *portion* must be substantial; moving only 5000 around won't do the trick. moving 50.000 away however and you will have one pile with 65.535 coins and another one with 50.000 gold coins.

This process can be repeated forever as long as you keep moving 50.000 out of the 65.535 pile.

I hope this is enough information. If not, I'll be happy to check it further out.

[giwo]

Ahh, it was the substantial amount part that I was missing.

I have reproduced this bug and will look into fixing it.

[giwo]

Found and fixed the cause of this one. Basically we were using a signed short when incrementing a stack (negatively or positively) which causes numbers beyond +/- 32767 to roll over. I would imagine if you attempted to move 32765 gold off of a stack of 65535 it would work just fine.

Anyhow this should be fixed for the next release.

[Fresshness]

by george, I think you've got it

Indeed, moving 32765 around is no problem.