[FIXED] Targeting a non-item when releasing lockdowns crashes server

[Xuri]

UOX3 version: 0.98.-4.0c

If you, when trying to release a locked-down item in a house, should happen to target a non-dynamic item or a map-tile, the server will crash.

The culprit, in void HouseRelease( CSocket *s ):

Code: Select all

	if( ValidateObject( itemToLock ) [color=red]|| !itemToLock->IsLockedDown()[/color] )

Not a very good idea to put an "or" statement there that tries to check a property of the target object even though the target isn't necessarily a valid object Fail!

I'm not even sure that it checks correctly. It seems to check if an object is NOT locked down, and if true, it allows you to continue with the item-release? Should maybe be the other way around - check if it IS locked down? Hm.

[Xuri]

Fix for this is up on CVS.

[giwo]

lol