[FIXED] Oil Cloth

Here we stuff all the bugs we've managed to squash/squish/squelch.
Locked
Puck
UOX3 Novice
Posts: 72
Joined: Sat Jan 23, 2010 3:22 pm
Has thanked: 0
Been thanked: 0

Oil Cloth

Post by Puck »

40g

Acquire some cloth, maybe 10 or so.

Make oil cloths.

See older oilcloth always get replaced by new one, or to put it another way, you will only hold 1 oilcloth at a time.
User avatar
Xuri
Site Admin
Posts: 3704
Joined: Mon Jun 02, 2003 9:11 am
Location: Norway
Has thanked: 48 times
Been thanked: 8 times
Contact:

Post by Xuri »

This seems to be caused by a shortcoming of UOX3's crafting system. The ID for the oil-cloths are the same as the ID for normal cloth, and that ID is included in the [RESOURCE CLOTH] entry in DFNDATA/CREATE/resources.dfn. So when you craft something it grabs the first available cloth from your backpack to use as resource - which just happens to be the oil cloth -_- The RESOURCE tag in the crafting DFNs does support a color argument, but it doesn't support NOT having a color argument properly, and when color isn't specified it will pick randomly amongst stuff like colored ingots (and oilcloth) when crafting non-colored items.

Temporary fix for tailoring: Change the ID of the oilcloth in both DFNDATA/ITEMS/GEAR/provisions.dfn as well as in DFNDATA/CREATE/tailoring.dfn, to the ID of a different item which is NOT defined as a "cloth resource".

Permanent fix for all crafting skills: Fix code so it doesn't grab resources which has a color other than 0x0 when crafting items that have a resource tag which doesn't specify a color!
-= Ho Eyo He Hum =-
giwo
Developer
Posts: 1780
Joined: Fri Jun 18, 2004 4:17 pm
Location: California
Has thanked: 0
Been thanked: 0

Post by giwo »

Couldn't you dye a stack of cloth blue then make blue shirts in UO?
User avatar
Xuri
Site Admin
Posts: 3704
Joined: Mon Jun 02, 2003 9:11 am
Location: Norway
Has thanked: 48 times
Been thanked: 8 times
Contact:

Post by Xuri »

I guess - but you wouldn't use cloth from your stack of blue cloth if you targeted a stack of uncolored cloth with your sewing kit (and the other way around), I think.

As it is now you will risk losing any colored ingots you might be carrying if you try to craft anything from normal iron ingots.
-= Ho Eyo He Hum =-
giwo
Developer
Posts: 1780
Joined: Fri Jun 18, 2004 4:17 pm
Location: California
Has thanked: 0
Been thanked: 0

Post by giwo »

Well the entire blacksmithy crafting system needed work, if I remember correctly. Bronze armor should only be craftable with bronze ingots and so on.

For those skills where you target the resource, only the target should be used, really.
User avatar
Xuri
Site Admin
Posts: 3704
Joined: Mon Jun 02, 2003 9:11 am
Location: Norway
Has thanked: 48 times
Been thanked: 8 times
Contact:

Post by Xuri »

Crafting the colored stuff actually works better than the non-colored stuff, because there it actively looks for a color on the resources it uses, while it doesn't for the normal stuff so it just picks the first and best that matches the resource-id, no matter which color.
-= Ho Eyo He Hum =-
Locked