[FIXED] Server crashes shortly after shorn sheep are killed

Here we stuff all the bugs we've managed to squash/squish/squelch.
Locked
User avatar
Xuri
Site Admin
Posts: 3704
Joined: Mon Jun 02, 2003 9:11 am
Location: Norway
Has thanked: 48 times
Been thanked: 8 times
Contact:

Server crashes shortly after shorn sheep are killed

Post by Xuri »

UOX3 version: 0.98-4.0c

If someone kills a newly shorn sheep, the server will crash when the effect-timer on said sheep runs out and it (the server) tries to change the body-ID of the aforementioned sheep into a wooly sheep again - since the object (aka sheep) the server is trying to change the ID for no longer exists.
Last edited by Xuri on Thu Jan 28, 2010 11:36 pm, edited 1 time in total.
-= Ho Eyo He Hum =-
User avatar
Xuri
Site Admin
Posts: 3704
Joined: Mon Jun 02, 2003 9:11 am
Location: Norway
Has thanked: 48 times
Been thanked: 8 times
Contact:

Post by Xuri »

Fix is up on CVS - added a ValidateObject line in effects.cpp before trying to switch sheep ID :P
-= Ho Eyo He Hum =-
RandallFlagg26
UOX3 Newbie
Posts: 16
Joined: Wed May 18, 2011 1:25 am
Has thanked: 0
Been thanked: 0

Post by RandallFlagg26 »

When you say "CVS" do you mean SourceForge?

If you do mean SourceForge.net then either I can't seem to find the correct file because the file modification dates aren't matching up with the dates of the posts and replies or I'm not looking in the right place.

If you don't mean SourceForge.net then where should I go to find the fix.

Many thanks in advance!!
User avatar
Xuri
Site Admin
Posts: 3704
Joined: Mon Jun 02, 2003 9:11 am
Location: Norway
Has thanked: 48 times
Been thanked: 8 times
Contact:

Post by Xuri »

I did mean SourceForge, yes - more specifically, the OpenUO SF project.

You can click here to see the change-history for effects.cpp (as well as the actual file, should you wish) in your browser through SF's CVS Browse feature.
-= Ho Eyo He Hum =-
giwo
Developer
Posts: 1780
Joined: Fri Jun 18, 2004 4:17 pm
Location: California
Has thanked: 0
Been thanked: 0

Post by giwo »

Hmm, I would think the destructor for the CNpc class would remove them from any trigger queues - guess it's not doing so currently. :)
Locked