[FIXED] UOX3 v0.99.4[RC3] (Win 64) Violated Me!

[Mindless Automaton]

Ok, fresh build this morning, dropped in community spawn and world files and then splat at end of server startup:

Code: Select all

>	UOX3.exe!CSocket::Send(CPUOXBuffer * toSend) Line 1439	C++
 	UOX3.exe!cItem::PlaceItem(CSocket * mSock, CChar * mChar, CItem * iCreated, const bool inPack) Line 638	C++
 	UOX3.exe!cItem::CreateScriptItem(CSocket * mSock, CChar * mChar, const std::basic_string<char,std::char_traits<char>,std::allocator<char> > & item, const unsigned short iAmount, const ObjectType itemType, bool inPack, const unsigned short iColor) Line 443	C++
 	UOX3.exe!cCharStuff::ApplyNpcSection(CChar * applyTo, ScriptSection * NpcCreation, std::basic_string<char,std::char_traits<char>,std::allocator<char> > sectionID, bool isGate) Line 880	C++
 	UOX3.exe!cCharStuff::CreateBaseNPC(UString ourNPC) Line 117	C++
 	UOX3.exe!CSpawnRegion::RegionSpawnChar() Line 620	C++
 	UOX3.exe!CSpawnRegion::doRegionSpawn(unsigned short & itemsSpawned, unsigned short & npcsSpawned) Line 598	C++
 	UOX3.exe!CWorldMain::CheckAutoTimers() Line 1264	C++
 	UOX3.exe!main(int argc, char * * argv) Line 2808	C++
 	[External Code]	

So I removed spawn/world, server starts ok. Add world files back, seems ok. Put spawn.dfn back and crash.

I deleted entries to spawn.dfn and narrowed it down to just Britain spawn.
m_animaltrainer, m_fisher & f_fisher cause a crash. (f_animaltrainer works fine).

For both fisher, removing PACKITEM=0x0dbf stops crash.
For m_animaltrainer removing GOLD=0 50 stops crash.

That cleared up the Britain spawns 0-49, however when I added all the other ones back, it crashes again. There are various lists and what not that contain creatures that use GOLD so I assume its related to that one.

Thanks!

[Xuri]

Thanks for testing, and for highlighting this! Easy fix, thankfully - just needed a null-check for socket before sending a tooltip update in the PlaceItem() function in items.cpp. It was trying to send container updates to a non-existent player Committed fix to branch.

[Mindless Automaton]

Thanks for testing, and for highlighting this! Easy fix, thankfully - just needed a null-check for socket before sending a tooltip update in the PlaceItem() function in items.cpp. It was trying to send container updates to a non-existent player Committed fix to branch.

No problemo, glad I can help narrow it done and get it fixed. I was able to build again and put in the spawn.dfn & wsc files and it seems to be running ok. Thanks!