[FIXED] Player Chars get sometimes deleted

[Grimson]

I recently noticed that after using the 'travel command my player char gets sometimes deleted when I'm logged out and a worldsave occurs. I think that happens since the last changes to region handling.

[giwo]

Quite likely happening because of the lack of brackets around the #ifdefs in ChangeRegion.

[Grimson]

Quite likely happening because of the lack of brackets around the #ifdefs in ChangeRegion.

I'm using release builds, so those ifdefs shouldn't affect anything.

[Grimson]

Way to reproduce it:

1. travel to britain - center
2. travel to green acres and walk a few steps.
3. travel back to britain - center.
4. shut the server down and start it back up.

This way my admin char get's deleted almost all the time.

[giwo]

No, you are using release builds so those ifdefs are causing the problem. Think about it, without the information in the ifdefs, the next thing below the if( Remove() ) statement is the if( Add ). So it's nesting the Add inside the remove, thus it only adds you if it CAN'T find you in the previous region.

I use debug 99% of the time which is why I didn't notice, in debug those statements work fine because of the #ifdef'd code.

[Grimson]

No, you are using release builds so those ifdefs are causing the problem. Think about it, without the information in the ifdefs, the next thing below the if( Remove() ) statement is the if( Add ). So it's nesting the Add inside the remove, thus it only adds you if it CAN'T find you in the previous region.

I see.

I use debug 99% of the time which is why I didn't notice, in debug those statements work fine because of the #ifdef'd code.

Then it's good that I use release most of the time .

[giwo]

*nod* Use of various different compilers helps as well, as sometimes one compiler pukes on a statement where another one has no problem.