[FIXED] UOX3 crashes when adding maptile or item to ones party

Here we stuff all the bugs we've managed to squash/squish/squelch.
Post Reply
User avatar
Xuri
Site Admin
Posts: 3704
Joined: Mon Jun 02, 2003 9:11 am
Location: Norway
Has thanked: 48 times
Been thanked: 8 times
Contact:

UOX3 crashes when adding maptile or item to ones party

Post by Xuri »

If, when using the /add command to add someone to your party, you accidentally (or on purpose) target the ground or a static/dynamic item instead of a character, UOX3 will crash.

Callstack:
UOX::CChar::IsValidPlayer() line 304 + 5 bytes
UOX::CChar::GetSocket() line 4418 + 8 bytes
UOX::PartyFactory::CreateInvite(UOX::CSocket * 0x18a34ce8) line 257 + 8 bytes
UOX::CPITargetCursor::Handle() line 1657 + 19 bytes
UOX::cNetworkStuff::GetMsg(unsigned long 0x00000000) line 561 + 17 bytes
UOX::cNetworkStuff::CheckMessage() line 442
UOX::cNetworkStuff::CheckMessages() line 1201
main(int 0x00000001, char * * 0x003d2508) line 2762
mainCRTStartup() line 338 + 17 bytes
KERNEL32! 7c816fd7()
Last edited by Xuri on Sun Jan 18, 2009 6:39 pm, edited 1 time in total.
-= Ho Eyo He Hum =-
giwo
Developer
Posts: 1780
Joined: Fri Jun 18, 2004 4:17 pm
Location: California
Has thanked: 0
Been thanked: 0

Post by giwo »

*frowns at Maarc*

Some error-checking would do nicely on targeting cursors. :)
Scott
Maarc
Developer
Posts: 576
Joined: Sat Mar 27, 2004 6:22 am
Location: Fleet, UK
Has thanked: 0
Been thanked: 0
Contact:

Post by Maarc »

Errr, ummm, ehhhh, it was, umm ... can I blame it on being a full moon that month?

Sorry about that guys.
User avatar
Xuri
Site Admin
Posts: 3704
Joined: Mon Jun 02, 2003 9:11 am
Location: Norway
Has thanked: 48 times
Been thanked: 8 times
Contact:

Post by Xuri »

Which one? Felucca or Trammel?

;)
-= Ho Eyo He Hum =-
giwo
Developer
Posts: 1780
Joined: Fri Jun 18, 2004 4:17 pm
Location: California
Has thanked: 0
Been thanked: 0

Post by giwo »

Actually the error-checking was there, you just forgot the return; :)
Scott
Post Reply