[FIXED] 'tweak not registering changes?

Here we stuff all the bugs we've managed to squash/squish/squelch.
Locked
neynadia
UOX3 Newbie
Posts: 13
Joined: Mon Jul 16, 2007 9:22 pm
Has thanked: 0
Been thanked: 0

'tweak not registering changes?

Post by neynadia »

After making a change in the 'tweak dialog box, and pressing "okay" there is no change registered. I did try changing the number of gold coins in my gold pile with no luck.

Code: Select all

'tweak

(tweak box where you pick something to edit)

(another box where you enter a value, select "okay")
Is that how it is supposed to go? (I assume it is just myself missing something, if not Vista.)

Running the newest version of UOX3, and Razor v1.0.7
User avatar
Xuri
Site Admin
Posts: 3704
Joined: Mon Jun 02, 2003 9:11 am
Location: Norway
Has thanked: 48 times
Been thanked: 8 times
Contact:

Post by Xuri »

Just to be clear... are you using the UOX3 version from the downloads page, or the "experimental" version from the sticky thread in general discussions, or one downloaded and compiled from CVS by yourself?

The CVS version, which I guess is "latest version", is 0.98-3.7o.
-= Ho Eyo He Hum =-
neynadia
UOX3 Newbie
Posts: 13
Joined: Mon Jul 16, 2007 9:22 pm
Has thanked: 0
Been thanked: 0

Post by neynadia »

Sorry, UOX3 from the downloads page (today).
User avatar
Xuri
Site Admin
Posts: 3704
Joined: Mon Jun 02, 2003 9:11 am
Location: Norway
Has thanked: 48 times
Been thanked: 8 times
Contact:

Post by Xuri »

Please download the experimental build (ignore the omnious name, as it's basically what will be the next official release of uox3), and report back if the problem still persists. :)
-= Ho Eyo He Hum =-
neynadia
UOX3 Newbie
Posts: 13
Joined: Mon Jul 16, 2007 9:22 pm
Has thanked: 0
Been thanked: 0

Post by neynadia »

*blush* I can't seem to find the experimental version. Could you please point me in the right direction?
User avatar
Xuri
Site Admin
Posts: 3704
Joined: Mon Jun 02, 2003 9:11 am
Location: Norway
Has thanked: 48 times
Been thanked: 8 times
Contact:

Post by Xuri »

Oops! Sorry, my fault. Here's a link.
-= Ho Eyo He Hum =-
neynadia
UOX3 Newbie
Posts: 13
Joined: Mon Jul 16, 2007 9:22 pm
Has thanked: 0
Been thanked: 0

Post by neynadia »

That fixes that! TG I hadnt put too much time into fiddling with the ini's :)

Thank you!
neynadia
UOX3 Newbie
Posts: 13
Joined: Mon Jul 16, 2007 9:22 pm
Has thanked: 0
Been thanked: 0

Post by neynadia »

Except that it doen't work well under Vista. :PP

But running them in "XP Compatability" seems to be doing the job.
User avatar
Xuri
Site Admin
Posts: 3704
Joined: Mon Jun 02, 2003 9:11 am
Location: Norway
Has thanked: 48 times
Been thanked: 8 times
Contact:

Post by Xuri »

Bumping this one, as 'TWEAK doesn't seem to actually do any changes, using UOX3 0.98-3.7r and UOML client version 5.0.8.4.
-= Ho Eyo He Hum =-
giwo
Developer
Posts: 1780
Joined: Fri Jun 18, 2004 4:17 pm
Location: California
Has thanked: 0
Been thanked: 0

Post by giwo »

The tweak menu seems to be working fine, the one exception I found was when the target had a serial of 0 (IE the first character created on the server).

I'll work on a fix for that issue, but if you can reproduce this outside of that scenario, let me know.

PS I'm using client version 6.0.1.5
User avatar
Xuri
Site Admin
Posts: 3704
Joined: Mon Jun 02, 2003 9:11 am
Location: Norway
Has thanked: 48 times
Been thanked: 8 times
Contact:

Post by Xuri »

Ah. I think I've found out why I've kept running into issues. By using admin-characters (who have access to all commands etc) that are not 'GMified' (they've been 'make player'd, for instance), I'm allowed to display the tweak menus and enter new values, but I'm guessing UOX3 chokes on a "if( mChar->IsGM() )" line in void CPIGumpInput::HandleTweakItemText( UI08 index ) so it stops before coming to the place where it actually applies the new values (and re-displays the tweak menu).
-= Ho Eyo He Hum =-
stranf
UOX3 Guru
Posts: 939
Joined: Wed Jan 04, 2006 3:59 pm
Has thanked: 0
Been thanked: 0

Post by stranf »

I know that I'm in the minority, but I would really like the option of giving normal PC players access to Tweak.

Since our shard is small, all of our quest GMers play normal PCs (so that they can die), and they have access to every JS script by means of the "RegisterCommand" function.

But like Xuri said, only true GM's (red coat, invulnerable and all) can make changes to tweak that works. So our PCs either have to use the tweak menu as a gump to see changes and use set to change them, or re-log in as a true GM.
giwo
Developer
Posts: 1780
Joined: Fri Jun 18, 2004 4:17 pm
Location: California
Has thanked: 0
Been thanked: 0

Post by giwo »

Good catch Xu, I'll change it to use the command level.

As for your request stranf, I'd like to eventually put the tweak menu's in JS so you can determine for yourself who should have access.
User avatar
Xuri
Site Admin
Posts: 3704
Joined: Mon Jun 02, 2003 9:11 am
Location: Norway
Has thanked: 48 times
Been thanked: 8 times
Contact:

Post by Xuri »

Hm. I logged in with a character on the admin acccount, with a serial higher than 0x0, did 'make player on him - then tried 'TWEAK with negative results (got the value-change dialogue, but no value-change actually took place).

Apparently, characters on the admin-account bypass commandlevel checks, as my character now has commandlevel 0 but can still use all commands.

'TWEAK works again when setting command-level to above 2.
-= Ho Eyo He Hum =-
User avatar
Xuri
Site Admin
Posts: 3704
Joined: Mon Jun 02, 2003 9:11 am
Location: Norway
Has thanked: 48 times
Been thanked: 8 times
Contact:

Post by Xuri »

Fixed on CVS, I added another check to see if character is on admin account. All admin-account characters will now be able to use this command no matter their commandlevel.

Note that for normal accounts it checks for a hardcoded commandlevel (CL_GM), so lowering the required commandlevel for TWEAK in commands.dfn will not give access to the command (unless the global commandlevel for GMs is also lowered).
-= Ho Eyo He Hum =-
stranf
UOX3 Guru
Posts: 939
Joined: Wed Jan 04, 2006 3:59 pm
Has thanked: 0
Been thanked: 0

Post by stranf »

you can lower the global command level for GMs?

Would this make all PC invulnerable? Or just give all PCs admin command control?
Locked