My Next Awesome Script! - spittoon.js

[Mindless Automaton]

I was brainstorming really hard trying to figure out what kind of script this emu was missing. (other than an exploding rabbit one)

And sudden, it hit me! A spittoon javascript!

Code: [Select all] [Expand/Collapse]

// Spittoon Script
// Mindless Automaton

function onUseChecked( pUser, iUsed )
{
    var isInRange = pUser.InRange( iUsed, 3 );
    if( !isInRange )
    {
        pUser.SysMessage( "You are too far away to reach that." );
        return false;
    }

    if( pUser.gender == 0 )
    {
        pUser.SoundEffect(0x446, true);
    }  

    if( pUser.gender == 1 )
    {
        pUser.SoundEffect(0x334, true);
    }  

    if( pUser.gender == 2 )
    {
        pUser.SoundEffect(0x22, true);

    }  
        pause(750);
        pUser.SoundEffect(0x2DF, true);
        return false;
}

function pause(millis)
{
    var date = new Date();
    var currentDate = null;

    do { currentDate = new Date(); }
    while (currentDate-date < millis);
}

GeSHi © Codebox Plus Extension

Woo hoo!

[Maarc]

Don't use your pause function. The server's single threaded, and what it will do is pause the entire server for 750 milliseconds. You don't want the entire world freezing every time someone uses a spittoon, surely?

Use a timer, there should be plenty of examples floating around for that.

[Mindless Automaton]

The problem was that the sounds played at the same time otherwise.

I'll check into the timer and check it out.

Thanks!

[Mindless Automaton]

Code: Select all

// Spittoon Script
// Mindless Automaton

function onUse( pUser, iUsed )
{
	var isInRange = pUser.InRange( iUsed, 3 );
	if( !isInRange )
 	{
		pUser.SysMessage( "You are too far away to reach that." );
		return false;
	}

	if( pUser.gender == 0 ) 
	{
		pUser.SoundEffect(0x446, true);
	}	

	if( pUser.gender == 1 ) 
	{
		pUser.SoundEffect(0x334, true);
	}	

	if( pUser.gender == 2 ) 
	{
		pUser.SoundEffect(0x22, true);

	}	
		iUsed.StartTimer( 750, 1, true );
		return false;
}

function onTimer( iUsed, timerID )
{
	if( timerID == 1 )
	{
		iUsed.SoundEffect(0x2DF, true);

	}
}