[FIXED] Thats what you GET! HA!

Here we stuff all the bugs we've managed to squash/squish/squelch.
Post Reply
Mindless Automaton
UOX3 Apprentice
Posts: 189
Joined: Wed May 10, 2006 3:48 am
Has thanked: 0
Been thanked: 1 time
Contact:

Thats what you GET! HA!

Post by Mindless Automaton »

If a DFN entry uses GET to refer to itself, it crashes the server by doing an infinite loop-o-matic.

No errors logged. :o

Not that I'd ever cause something like that to happen.. <cough>

sample file:
(test.dfn)

[bunny]
{
GET=bunny
NAME=a fluffy bunny
STR=15
DEX=25
INT=5
HPMAX=9
DAMAGE=2 5
TOPROV=59
TOPEACE=59 5
RACE=9
}

load dfns, add npc bunny, click to place, CRASH.
Mindless Automaton
Linux - UOX3 - 0.99.5 dev branch
Win10Pro 19042.572 - UOX3 0.99.3a; Razor 1.0.14; Client 7.0.87.11 or 4.0.11c (Patch 0)
User avatar
Xuri
Site Admin
Posts: 3704
Joined: Mon Jun 02, 2003 9:11 am
Location: Norway
Has thanked: 48 times
Been thanked: 8 times
Contact:

Post by Xuri »

Lol :D Nice one.
-= Ho Eyo He Hum =-
giwo
Developer
Posts: 1780
Joined: Fri Jun 18, 2004 4:17 pm
Location: California
Has thanked: 0
Been thanked: 0

Post by giwo »

Infinite loops r0xx0r!
giwo
Developer
Posts: 1780
Joined: Fri Jun 18, 2004 4:17 pm
Location: California
Has thanked: 0
Been thanked: 0

Post by giwo »

Relatively simple fix, I'll put it up in my next commit
User avatar
Xuri
Site Admin
Posts: 3704
Joined: Mon Jun 02, 2003 9:11 am
Location: Norway
Has thanked: 48 times
Been thanked: 8 times
Contact:

Post by Xuri »

Tested, and verified fixed in 0.98-4.0.
Console gives the following warning message when spawning the NPC, and no crash occurs:
WARNING: Infinite loop avoided with GET tag inside character script BUNNY
-= Ho Eyo He Hum =-
Post Reply